Offline Mode for zingo-mobile #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dorianvp can this be tested with Kotlin in zingo-mobile? Or detox? |
zancas
reviewed
Nov 22, 2024
zancas
approved these changes
Nov 27, 2024
|
|
||
| let valid_uri = crate::config::construct_lightwalletd_uri(Some( | ||
| crate::config::DEFAULT_LIGHTWALLETD_SERVER.to_string(), | ||
| )); |
There was a problem hiding this comment.
I don't really think this test is correct, I see valid_uri with a valid uri, hehehehe, obviously, and IMO this test needs a different value here, IDK like http::Uri::default() which for me is a empty server uri.
| ) | ||
| .unwrap(); | ||
|
|
||
| assert_eq!(valid_config.get_lightwalletd_uri(), valid_uri); |
There was a problem hiding this comment.
this make no sense to me... in a serverless scenario... in fact the normal situation for serverless is:
- server uri: empty.
- chain type: empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.